Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about setup.template.overwrite to documentation and reference configuration #22357

Merged
merged 2 commits into from
Nov 3, 2020

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Nov 2, 2020

What does this PR do?

This PR adds a warning about setup.template.overwrite option.

Why is it important?

Users might enable this option and then start multiple instances of Beats at the same time. This can overload Elasticsearch with too many template update requests.

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kvch kvch requested review from a team as code owners November 2, 2020 16:24
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 2, 2020
@kvch kvch added the Team:Services (Deprecated) Label for the former Integrations-Services team label Nov 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 2, 2020
@kvch kvch force-pushed the docs-libbeat-template-overwrite-warning branch from 7b56e13 to ea17fe7 Compare November 2, 2020 16:45
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 2, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22357 updated]

  • Start Time: 2020-11-02T18:24:52.121+0000

  • Duration: 76 min 58 sec

Test stats 🧪

Test Results
Failed 0
Passed 16383
Skipped 1344
Total 17727

@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 16383
Skipped 1344
Total 17727

@kvch kvch merged commit 8798d41 into elastic:master Nov 3, 2020
@kvch kvch added the v7.11.0 label Nov 4, 2020
kvch added a commit to kvch/beats that referenced this pull request Nov 4, 2020
…ence configuration (elastic#22357)

This PR adds a warning about `setup.template.overwrite` option.

Users might enable this option and then start multiple instances of Beats at the same time. This can overload Elasticsearch with too many template update requests.

(cherry picked from commit 8798d41)
@kvch kvch added the v7.10.0 label Nov 4, 2020
kvch added a commit to kvch/beats that referenced this pull request Nov 4, 2020
…ence configuration (elastic#22357)

This PR adds a warning about `setup.template.overwrite` option.

Users might enable this option and then start multiple instances of Beats at the same time. This can overload Elasticsearch with too many template update requests.

(cherry picked from commit 8798d41)
kvch added a commit that referenced this pull request Nov 6, 2020
…ence configuration (#22357) (#22416)

This PR adds a warning about `setup.template.overwrite` option.

Users might enable this option and then start multiple instances of Beats at the same time. This can overload Elasticsearch with too many template update requests.

(cherry picked from commit 8798d41)
kvch added a commit that referenced this pull request Nov 6, 2020
…ence configuration (#22357) (#22415)

This PR adds a warning about `setup.template.overwrite` option.

Users might enable this option and then start multiple instances of Beats at the same time. This can overload Elasticsearch with too many template update requests.

(cherry picked from commit 8798d41)
Leaf-Lin added a commit to elastic/apm-server that referenced this pull request Nov 27, 2020
Similar to elastic/beats#22357, setup.template.overwrite could potentially overload Elasticsearch with too many update requests. 
On Elasticsearch side, it will be addressed in newer versions by introducing no-op updates which will be available from 7.11+ elastic/elasticsearch#64493

See also elastic/elasticsearch#57662

Thought having some warnings in the APM setting here should prevent users unwittingly leave template auto-creation on across large number of APM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Services (Deprecated) Label for the former Integrations-Services team v7.10.0 v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants