-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning about setup.template.overwrite to documentation and reference configuration #22357
Merged
kvch
merged 2 commits into
elastic:master
from
kvch:docs-libbeat-template-overwrite-warning
Nov 3, 2020
Merged
Add warning about setup.template.overwrite to documentation and reference configuration #22357
kvch
merged 2 commits into
elastic:master
from
kvch:docs-libbeat-template-overwrite-warning
Nov 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Nov 2, 2020
kvch
added
the
Team:Services
(Deprecated) Label for the former Integrations-Services team
label
Nov 2, 2020
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Nov 2, 2020
kvch
force-pushed
the
docs-libbeat-template-overwrite-warning
branch
from
November 2, 2020 16:45
7b56e13
to
ea17fe7
Compare
Collaborator
dedemorton
requested changes
Nov 2, 2020
Co-authored-by: DeDe Morton <[email protected]>
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
dedemorton
approved these changes
Nov 2, 2020
2 tasks
kvch
added a commit
to kvch/beats
that referenced
this pull request
Nov 4, 2020
…ence configuration (elastic#22357) This PR adds a warning about `setup.template.overwrite` option. Users might enable this option and then start multiple instances of Beats at the same time. This can overload Elasticsearch with too many template update requests. (cherry picked from commit 8798d41)
2 tasks
kvch
added a commit
to kvch/beats
that referenced
this pull request
Nov 4, 2020
…ence configuration (elastic#22357) This PR adds a warning about `setup.template.overwrite` option. Users might enable this option and then start multiple instances of Beats at the same time. This can overload Elasticsearch with too many template update requests. (cherry picked from commit 8798d41)
kvch
added a commit
that referenced
this pull request
Nov 6, 2020
…ence configuration (#22357) (#22416) This PR adds a warning about `setup.template.overwrite` option. Users might enable this option and then start multiple instances of Beats at the same time. This can overload Elasticsearch with too many template update requests. (cherry picked from commit 8798d41)
kvch
added a commit
that referenced
this pull request
Nov 6, 2020
…ence configuration (#22357) (#22415) This PR adds a warning about `setup.template.overwrite` option. Users might enable this option and then start multiple instances of Beats at the same time. This can overload Elasticsearch with too many template update requests. (cherry picked from commit 8798d41)
Leaf-Lin
added a commit
to elastic/apm-server
that referenced
this pull request
Nov 27, 2020
Similar to elastic/beats#22357, setup.template.overwrite could potentially overload Elasticsearch with too many update requests. On Elasticsearch side, it will be addressed in newer versions by introducing no-op updates which will be available from 7.11+ elastic/elasticsearch#64493 See also elastic/elasticsearch#57662 Thought having some warnings in the APM setting here should prevent users unwittingly leave template auto-creation on across large number of APM.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a warning about
setup.template.overwrite
option.Why is it important?
Users might enable this option and then start multiple instances of Beats at the same time. This can overload Elasticsearch with too many template update requests.
Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.